Update language with url params resulted mixing page locale

Actual Behavior

Using lang parameter depending on configuration set-up causing mixed page locale selection.

Expected Behavior

Given language by using lang parameter should reflect completely on current page locale without depending on your environment setup.

Steps to Reproduce the Bug Strange behaviour exist if follow steps to set-up environment and execute;

• Set-up different initial locales between;
  • LOCALE_ID which is used to set default locale at configuration.module.ts:47 (Able to control explicitly by using providers: [{provide: LOCALE_ID, useValue: 'fr-FR'}])
  • First available of locale from locales at environment.prod.ts or environment.ts (Current setup using en_US as a first available locale)
• Assume we have fr_FR as default locale from LOCALE_ID and en_US as first locale from environment.prod.ts or environment.ts
• Run application, npm start
• Try to navigate http://localhost:4200/home;lang=fr_FR
• See mixing over selected locale and page content.
  • 

Environment Details

Desktop:

• Chrome 80.0.3987.163
• PWA 0.18

Possible Root Cause

• Application causing repeating language switch within short period of time, which triggers known ngx-translate issue ngx-translate/core#1030,
• As a result application state switched correct language, loaded translation may differs,
• Adding defer times while switching language like using debounceTime or removing possible repeated language switch with same language code two times or more by using translateService.use or translateService.setDefaultLang which is leading translation loads in wrong order.

[dhhyi]

Yes, NOW I get it. Sorry it took me so long, must be one of my bad days. 😅

Debouncing actually works. Just re-scheduling with delay zero does also work for me. Can you please double-check? Thank you for pointing me the right way.

Do you mind if I add you as an author to that commit? #karma 😉

[anumang]

@dhhyi, thank you for understanding and resolving the issue 🎉.

At the end, We just made a temporary solution but still I am happy to be part of it 😃 So it’s not necessity but as you wish if you count me as an author for this fix.

My long term expectations,

Translation library should bring stable fix for their issue if they decide to wont-fix for their race condition issue and suggest developers to update locales only once, you may need to re-evaluate ISH locales architecture / logic from scratch or may switch another possible solutions which you mentioned with possible changes after angular 9 upgrade.