npm plugin does not bump the version in package.json
See original GitHub issueDescribe the bug
The package.json
is not updated, when running (yarn/npx) auto shipit
on a pre-release branch.
(yarn/npx) auto shipit --dry-run --quiet
is not reporting the correct version number in that case.
This causes issues downstream as the version number is used to tag docker images and other artifacts.
To Reproduce
- Commit on
next
auto shipit
runs in Github Actionauto
released correctly to github- Package json did not update
Expected behavior
Either package.json updates, or auto shipit --dry-run
calculates based on tags for prereleases.
Environment information: “Current version” is wrong here already, the current tag is v0.2.0-next.11
yarn run v1.22.10
$ /home/rwa/Project/####/node_modules/.bin/auto info
Environment Information:
"auto" version: v9.59.1
"git" version: v2.29.0
"node" version: v14.14.0
Project Information:
✔ Repository: #####
✔ Author Name: Robert Wawrzyniak
✔ Author Email: robert.wawrzyniak@###.de
✔ Current Version: v0.2.0-next.10
✔ Latest Release: v0.1.0 (https://github.com/####/releases/tag/v0.1.0)
✔ Labels configured on GitHub project
GitHub Token Information:
✔ Token: [Token starting with 62de]
✔ Repo Permission: admin
✔ User: thuringia
✔ API: undefined (undefined)
✔ Enabled Scopes: repo
✔ Rate Limit: 4772/5000
Done in 3.39s.
Time: 0h:00m:04s
Additional context This might be related to #1490 ?
This appears to be by design: https://github.com/intuit/auto/blob/2f03089f43cc098ac2687c7ab3ca5fd8d2502a1c/plugins/npm/src/index.ts#L869 The bump is only run for base branches here, but there is no config flag to change this.
Issue Analytics
- State:
- Created 3 years ago
- Comments:14
Top GitHub Comments
Ah, another vote for me fixing dry-run behavior sooner rather than later. Will take a look at fixing all of that next weekend. Thanks for the feedback and using
auto
!@thuringia @smithki Could you test and see if v10 solves your issues?