[4.12.0] [ion-picker] dismiss function doesn't pass data and role data to onDidDismiss

Bug Report

Ionic version:

4.12.0

Current behavior: When the ion-picker gets dismissed the onDidDismiss() data and role properties are both undefined.

Expected behavior: When the picker gets dismissed it should have the role parameter set. E.g. When closing via a Button with that button’s role. So we can perform some action based on whether the user clicked the button or not

Steps to reproduce: Create a picker, present it and tap on one of the buttons so the onDidDismiss() method is called.

const picker = await this.pickerController.create({
  buttons: [
   {
     text: 'CANCEL',
     role: 'cancel'
   },
   {
     text: 'CONFIRM',
     role: 'confirm'
   }
  ],
  columns: [
    {
      name: 'column',
      options: [
        {
          text: 'First',
          value: 'first'
        },
        {
          text: 'Second',
          value: 'second'
        }
      ]
    }
  ]
});

picker.present();

const dismiss = await picker.onDidDismiss();
console.log('Dismissed picker', dismiss);
if(dismiss.role === 'close') {
  console.log('Close button pressed!');
}

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.12.0
   Ionic Framework               : @ionic/angular 4.2.0
   @angular-devkit/build-angular : 0.13.6
   @angular-devkit/schematics    : 7.2.4
   @angular/cli                  : 7.2.4
   @ionic/angular-toolkit        : 1.4.0

Cordova:

   cordova (Cordova CLI) : 9.0.0 (cordova-lib@9.0.1)
   Cordova Platforms     : not available
   Cordova Plugins       : not available

System:

   NodeJS : v10.16.0 (/home/dletran/.nvm/versions/node/v10.16.0/bin/node)
   npm    : 6.9.0
   OS     : Linux 4.13

[brandyscarney]

PR submitted here: https://github.com/ionic-team/ionic/pull/19787

Dev release is based on the 5.0.0-beta.0 release: 5.0.0-dev.201910292106.aebfdfc

[hidertanure]

Hi guys, As a workaround, my issue was solved using the handler callback like this:

{ text: 'Done', role: 'select', handler: (value) => { console.log(value); } }

Don’t need to use the onDidDismiss anymore.