bug: cannot use IonItem with IonRouter on React-Tests
See original GitHub issueBug Report
Ionic version:
[ ] 4.x [x] 5.x
Current behavior:
Cannot use IonItem with IonRouter on React Tests at “/packages/react/test/test-app/”. Getting error: Property 'routerAnimation' is missing in type '{ children: Element[]; button: true; }' but required in type 'Pick<IonItem, "color" | "button" | "disabled" | "lines" | "mode" | "href" | "routerAnimation" | "rel" | "target" | "download" | "type" | "detail" | "detailIcon">'. TS2741
Expected behavior: IonRouter should get the property routerAnimation.
Steps to reproduce: See steps: https://github.com/ionic-team/ionic-framework/issues/22342#issuecomment-723108406
Related code: https://github.com/ionic-team/ionic-framework/tree/master/packages/react/test/test-app
Other information: Issue #22342 cannot be fixed without testing and fixing this issue…
Ionic info: Cannot give ionic info because of working in the Source Code of Ionic Framework.
Issue Analytics
- State:
- Created 3 years ago
- Comments:5 (2 by maintainers)
Top GitHub Comments
@liamdebeasi It works now. It has to be like this:
/packages/react-router/test-app/package.json
and/packages/react-router/test-app/build.sh
sh build.sh
in /packages/react-router/test-app/npm install
in /packages/react-router/test-app/npm start
in /packages/react-router/test-app/Unfortunately on my MacBook
npm install
did not work, butnpm install --force
. Thanks for helping, I can now focus on #22342For 1) make sure you have run
npm install
first.For 2) follow these steps:
ionic-react-5.5.0
in bothpackage.json
andbuild.sh
toionic-react-5.5.5
. This assume you have the latestmaster
../build.sh
. This assumes you have installed dependencies in thereact
directory first.The steps here are not the most intuitive, so I can document these somewhere in the readme.