bug: react, router.go does not show correct view when n < -1
See original GitHub issuePrequisites
- I have read the Contributing Guidelines.
- I agree to follow the Code of Conduct.
- I have searched for existing issues that already report this problem, without success.
Ionic Framework Version
- v4.x
- v5.x
- v6.x
Current Behavior
Navigating using router.go(n)
with an n
value less than -1
, Ionic React does not show the correct view because it always assumes a delta of 1
or -1
.
Expected Behavior
I would expect Ionic React to show the correct view regardless of the delta value.
Steps to Reproduce
- Start with one page and push 2 IonPages to navigation stack via navigation.push()
- Let the 3rd page navigate back (“history stack pop”) to the first page via navigation.go(-2)
- Observe that react’s router does produce the proper URL (path) of the first page. But also observe that the the previous route (page) in the history stack is rendered, not the very first page which belongs to that path.
Code Reproduction URL
https://github.com/larsblumberg/ionic-back-navigation-broken
Ionic Info
No response
Additional Information
This is a continuation of https://github.com/ionic-team/ionic-framework/issues/22563.
At the time of writing, there does not seem to be a straightforward way to implement this. The fix for this in Ionic Vue relied on Vue Router exposing a delta value as well as a custom state object in window.history.state
that let us track which view to show. React Router does not expose this kind of information according to https://github.com/remix-run/history/issues/36#issuecomment-233652964 and https://github.com/remix-run/history/issues/334#issuecomment-244250026.
One option is we could build this position tracking into Ionic React ourselves, but I am a bit hesitant to start altering window.history.state
especially when React Router already manages the state for us.
Issue Analytics
- State:
- Created 2 years ago
- Reactions:3
- Comments:5
Top GitHub Comments
Is there a workaround for this? How can one return multiple pages back in the history stack? Looks like Ionic 6 RC for React has the same issue.
is there are workaround for this? this is a huge blocker for me