feat: Dynamic breakpoints for Sheet Modals
See original GitHub issuePrerequisites
- I have read the Contributing Guidelines.
- I agree to follow the Code of Conduct.
- I have searched for existing issues that already include this feature request, without success.
Describe the Feature Request
Sheet modals can have dynamic content within their container. When the content changes, the height of the sheet modal can also change. Sheet modals should offer the ability to the developer, to update the breakpoint values dynamically, so that the sheet modal will both animate to the updated height smoothly as well as the clip point for the breakpoint will respond to the updated height.
Describe the Use Case
Twitter spaces highlights this example perfectly.
<video src="https://user-images.githubusercontent.com/13732623/160919276-7713f2af-d640-4fb1-9170-1ac34b6ce3d7.mp4"></video>
Initial Breakpoint | Max Breakpoint |
---|---|
When the number of participants in a Twitter space increases, the height of the modal will also increase, changing the breakpoint value:
Updated Breakpoint | Max Breakpoint |
---|---|
Describe Preferred Solution
Dynamic breakpoints should happen automatically, with limited customization from the implementer. For example:
<ion-modal [breakpoints]="breakpoints"></ion-modal>
breakpoints = [0, 0.25];
onClick() {
this.breakpoints = [0, 0.5];
}
Developers should be able to update the value of breakpoints
at any point once the sheet modal is presented and the sheet modal should respond and update accordingly.
Describe Alternatives
Other options have been explored here: https://github.com/sean-perkins/modal-sheet-hans
- Presenting a new sheet modal when the state changes. Functional, but the transition between dismissing the previous sheet modal and presenting the new sheet modal is noticeable and not ideal.
- Dynamically changing the height of the modal. Displays similarly, but does not transition between height changes. Also the gesture behavior responds incorrectly.
Related Code
Supporting this internally will require changes similar to: https://github.com/ionic-team/ionic-framework/commit/f08456700246e7b14ef9eb2354bfdd9499a76d74
We will need to safeguard against instances where:
- The current breakpoint is no longer in the list of available breakpoints
- The sheet gesture needs to be re-created as a result of the breakpoints being modified
Additional Information
Duplicate feature request as: #24752, with updated use case.
Issue Analytics
- State:
- Created a year ago
- Reactions:10
- Comments:7 (5 by maintainers)
@Juanjo3299 6.1 should be released after their current sprint around April 13th
@Juanjo3299 That feature will be available in 6.1.0. When a breakpoint is modified, either from programmatically changing it or dragging the sheet,
ionBreakpointDidChange
will emit with the new breakpoint value.