Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
feat: pass T in onDidDismiss to OverlayEventDetail
See original GitHub issueFeature Request
the onDidDismiss, e.g. for a Modal, returns OverlayEventDetail<any>.
The any is poor for coding, it would be better to be able to pass T.
Right now onDidDismiss is defined like so:
"onDidDismiss": () => Promise<OverlayEventDetail<any>>;
please change to
"onDidDismiss": <T = any>() => Promise<OverlayEventDetail<T>>;
so T is still optional, but if you want, you can have it typed now.
Ionic version:
[x] 4.x
Describe the Feature Request
Describe Preferred Solution
Describe Alternatives
Related Code
Additional Context
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:9 (5 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
@nickwinger Yes, I’ll try to find such methods, but if there are too many such methods I think that the best solution is to split such PR to many.
In the first iteration, I can find all the possible places and describe them in the comments of this task.
Yes, thank you!
Here is our contributing guide that gives you an overview of how to make the changes, test, and create a PR: https://github.com/ionic-team/ionic/blob/master/.github/CONTRIBUTING.md#creating-a-pull-request.
Let me know if you have any questions 😊.