[Ionic v4] Attribut no-margin doesn't set --margin variables to zero

Ionic Info @ionic/angular: “4.0.0-alpha.11”

Describe the Bug Using the attributes no-margin on an element doesn’t set the css4 variables --margin zero

Steps to Reproduce For example:

 <ion-button no-margin no-padding>Something</ion-button>

no-margin will be generate as

 ion-app [no-margin] {
    margin: 0;
 }

where no-padding will be correctly generated as

[no-padding] {
   padding: 0;
   --padding-start: 0;
   --padding-end: 0;
   --padding-top: 0;
   --padding-bottom: 0;       
}

Expected output

 ion-app [no-margin] {
    margin: 0;
   --margin-start: 0;
   --margin-end: 0;
   --margin-top: 0;
   --margin-bottom: 0;  
 }

[peterpeterparker]

Tested, I could confirm the fix in v4.0.0-alpha.12, thx 👍

[brandyscarney]

@peterpeterparker Thanks 🙂 They’re related and hopefully we’ll solve them both at once but I’ll leave this open to make sure it gets fixed.