question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Move iov-ledger-bns into separate repo

See original GitHub issue

I really like the monorepo approach, but over 90% of the errors I have ever encountered building the repo have had to do with libusb. This is only used by the ledger app, and maybe it would make sense to pull this package into it’s own repo to make the rest more accessible.

Note the principle issue we have documented in the FAQ: https://github.com/iov-one/iov-core#libusb-fails-to-build-why

What do other people think? 👍? 👎?

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:2
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
webmaster128commented, Oct 9, 2018

With refactorings like https://github.com/iov-one/iov-core/issues/415 and https://github.com/iov-one/iov-core/issues/302 ongoing, I don’t think it makes sense to extract @iov/ledger-bns at the moment. It would be very inconvenient do do those chances over two repos because you always need to release core first before you can apply the update to ledger-bns. I think we should wait for more stable interfaces before doing this move.

0reactions
webmaster128commented, Nov 14, 2018

Closing this as I see more disadvantages than advantages. Please re-open if very strong arguments for separation come up.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Splitting a subfolder out into a new repository - GitHub Docs
You can turn a folder within a Git repository into a brand new repository. ... Git history or changes when you split a...
Read more >
How to move a git repository with history | Atlassian Git Tutorial
Go into the temp-dir directory. 3. To see a list of the different branches in ORI do: git branch -a. git branch ...
Read more >
Detach (move) subdirectory into separate Git repository
I want to split out a single folder, btoa , into a separate Git repository cd ~/node-browser-compat/ git subtree split -P btoa -b...
Read more >
Move files from one repository to another, preserving git history
Moving the files with history to a different repository requires the following steps: Getting files ready to move from Repository A. Step 1: ......
Read more >
Git: Moving a sub-directory to a new repo with history - YouTube
I needed to move a directory within a git repo to its own repo, but I wanted to preserve commit history. Using a...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found