Menu items for enabling pubsub and automatic GC
See original GitHub issueI was looking into starting go-ipfs with additional flags: --enable-pubsub-experiment
(pubsub) and --enable-namesys-pubsub
(IPNS over pubsub) and the main concern I’ve found was use of resources:
In order to enable pubsub by default in go-ipfs, we need to find some way for pubsub to not take up a bunch of resources when not in-use. – https://github.com/libp2p/go-libp2p-pubsub/issues/332
So if we want pubsub and fast IPNS enabled, we need to pay the cost of higher resource utilization. We could measure it and decide if its worth the added value, or prioritize a fix.
Updated: or at the very least, we could give user UI for enabling that with one click
Updated again: See mockup for placement of menu items for pubsub and automatic GC (note this also includes not-yet-implemented “Ask when opening” menu item, likely to land first in https://github.com/ipfs-shipyard/ipfs-desktop/issues/1646)
@aschmahmann are there any other concerns that I don’t see?
@autonome FYSA this also impacts go-ipfs in Brave, especially the speed of ipns://
Issue Analytics
- State:
- Created 3 years ago
- Comments:9 (8 by maintainers)
Top GitHub Comments
Note: Added mockup of menu item placement in original comment.
Unless @aschmahmann or @autonome have objections, I believe this is ready to work.
Opened a pull request to add the pubsub option: https://github.com/ipfs-shipyard/ipfs-desktop/pull/1735
If that goes well then I’ll open another with the automatic GC option.