Does Grace support IAsyncDisposable?

Does Grace automatically dispose not only services implementing IDisposable but also the newly introduced (.NET Standard 2.1 / .NET Core 3.0) async version named IAsyncDisposable?

[Lex45x]

Cool, I’ve already started working on it.
Basically, we will have to make changes in the Grace and then in the Grace.DependencyInjection.Extensions package. I will open PR to Grace throughout next week, so we can discuss.

A few points I want to highlight:

1. IAsyncDisposable supported from netstandard2.1, so I will add a new target framework and implement changes only for netstandard2.1.
2. According to Microsoft documentation on using IAsyncDisposable and IDisposable simultaneously, IDisposable implementation will not be responsible for IAsyncDisposable resources cleanup. Related discussion is here.

[Lex45x]

the question would be what’s the use case as asp.net core won’t perform an async dispose of the container when shutting down so you’d need to call it yourself.

I will check that in detail, but as I can already see, AspNetCore 5.0+ supports IAsyncDisposable service providers:

https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.dependencyinjection.serviceprovider?view=dotnet-plat-ext-5.0 https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.http.httpresponse.registerfordisposeasync?view=aspnetcore-5.0