Badly behaving setup.py

Changing distribution metadata (such as install_requires) in setup.py according to some vague ideas on how (pip|setuptools|…) works is a horrid idea. More specifically, try this:

1. Use pip-tools (version 1.9 or later) to compile the following requirements.in on OSX:

ipython

1. Note that appnope (only useful on OSX) is included in the resulting requirements.txt, without any environment markers - it should be only for :sys_platform == "darwin".

I’ll put together two PRs (one for master, the other for 5.x) that limits the insanity to old versions of pip (<6).

[Carreau]

I’ll put together two PRs (one for master, the other for 5.x) that limits the insanity to old versions of pip (<6).

If you have pip <6 anyway IPython will likely fails to install (mostly on python 2) as pi will download IPython 6 and try to install it while it’s not compatible. So I think that expecting users to have a recent pip is reasonable.

Happy to get a PR making things better though. Don’t spend too much time on a PR for 5.x if the PR for master does not conflict, our bot will be able to auto backport.

Thanks !

[Carreau]

Hi, I stumbled upon the issue with appnope and pip-tools and want to contribute. Would it be reasonable to add platform environment marker for each platform dependent package (pexpect, appnope, colorama) in both install_requires and extras_require? For example, ; sys_platform == "darwin" for appnope

Yes, that would be reasonable, and in general reasonable to move away from setup.py to a pyproject.toml, but that might require some refactor of the directory structure. Any improvement/ simplification welcome.