Notes of expired transaction should be removed

What happened?

Incorrect pending balance. When we create a new transaction, we use account.syncTransaction to update notes in db. However, for transactions that are not mined before expiration sequence, something unexpected happens.

Your balance is made of notes on the chain that are safe to spend
Balance: $IRON 0.79998400

0 notes worth 0.00000000 are on the chain within 12 blocks of the head
Unconfirmed: 0.79998400

1 notes worth 1.00000000 are waiting for miners to add them to the chain
Pending: 1.79998400

 Status     Creator Hash                                   Miner Fee Fee ($IRON)         Notes Spends Expiration Sequence
 ────────── ─────── ────────────────────────────────────── ───────── ─────────────────── ───── ────── ───────────────────
 confirmed  ✔       9af35cbe06f45d58dea9720eb4366ddbc706d… x         0.00000800          2     1      227327
 confirmed  x       ea0d7631889ce0e934cd9bd2bba399931fe0a… x         0.00005000          2     1      227089
 expired    x       569c8aa82142768410c36ef585c12ba8641c0… x         0.00000500          2     1      227082
 unconfirmed ✔       e6d1d70085f0b1afce89cbf19e0e491a08fe… x         0.00000800          2     1      227356

 Amount ($IRON) Memo       From Transaction                                                 Spent
 ────────────── ────────── ──────────────────────────────────────────────────────────────── ─────
 1.00000000     test 9246cccd66674f2b60740e36a499debdc825f3d3e0ffe040054791db0dd3941a x (from expired transaction)
 0.79998400          b59b1daa28943bfef19b75a3203bd6a89183c37778984d9dafb2eea1c051dfb4 x
 0.89999200          204640b16924cf0c1349a74c1f4caf81d9f62939e4f07908c2478db32d90242c ✔
 1.00000000     test2 4fa27b50544ed0caf63894d40869ec678bf64cba2ebcda3ebee7942fb93420b0 ✔

Version

0.1.49 @ src

Debug output

No response

Relevant log output

No response

Graffiti

miningKing

[hughy]

Status of notes already spent is first marked as spent when I create a transaction to spend it, then it changes and rolls back to unspent.

That’s very helpful, thanks for all of the details in the comments here!

[hughy]

Resolved in #2399