Clone fails on Node: global.fetch is not a function

From a quick scan, it looks like as of this change in January 2019 http module no longer checks for global.fetch, which excludes Node environment.

I was accidentally stuck on 0.50 version, and once I updated (for the sake of fastCheckout and other niceties) I’m getting the following stack trace when cloning:

  16:00:17.707 › UnhandledRejection TypeError: global.fetch is not a function
      at http (webpack-internal:///./node_modules/isomorphic-git/dist/for-future/isomorphic-git/index.js:4931:28)
      at Function.discover (webpack-internal:///./node_modules/isomorphic-git/dist/for-future/isomorphic-git/index.js:5162:21)
      at fetchPackfile (webpack-internal:///./node_modules/isomorphic-git/dist/for-future/isomorphic-git/index.js:5975:42)
      at fetch (webpack-internal:///./node_modules/isomorphic-git/dist/for-future/isomorphic-git/index.js:5840:22)
      at Module.clone (webpack-internal:///./node_modules/isomorphic-git/dist/for-future/isomorphic-git/index.js:6321:42)

From cursory search, it seems like global.fetch isn’t supposed to be available on Node. Is reinstating the previous Node-compatible state of http’s fetching logic on the table?

[wmhilton]

Yes… it’s really a webpack configuration issue. Webpack is probably trying to use the module file instead of the main file, but

• the module file uses ES6 modules and is “for web” while
• the main file uses CommonJS modules and is “for node”

Which 99% of the time is right, because Webpack is usually not used on Node.js apps. You can probably make Webpack use the “right” version with an alias to dist/for-node/isomorphic-git/index.js but if you’re using webpack and isomorphic-git on both the node-side and the browser-side of an Electron app, you’d need separate webpack config files…

Anyway, as you can see it’s obviously a bit of a mess. And I am going to fix this in version 1.0 by pulling this troublesome bit out of the library completely and make users provide an HTTP client, just like what I already do for fs. That way the code doesn’t have to try and detect whether it’s running in Node or be compiled differently.

[strogonoff]

@wmhilton I believe https://www.electron.build? That’s what we’re using!