Files marked as *modified after clone

I am using Node, on Windows

Problem

On Windows and with some repositories, isogit is telling me that all files are modified just after cloning the repo.

This is blocking me because I can’t find which files have been changed locally since the last commit

Steps to reproduce

npm i -g isomorphic-git
git clone https://github.com/acailly/isomorphic-git-issue-1275.git
cd isomorphic-git-issue-1275
isogit status --filepath="README.md"
> "*modified"

This is not reproduced on other repo like https://github.com/isomorphic-git/isomorphic-git.git

I do not reproduce it on the Ubuntu executed in WSL2 (Windows Subsystem for Linux), where the displayed status is correct (unmodified )

[acailly]

I confirm this is a crlf issue, if I change GitObject.wrap implementation from

https://github.com/isomorphic-git/isomorphic-git/blob/f2e38053733f4c8ca4b7784d5c2a56addcf36bf4/src/models/GitObject.js#L4

to

class GitObject {
  static wrap({ type, object }) {
    // This is a quick and dirty fix
    const objectWithoutCRLF = Buffer.from(object.toString("utf8")
      .replace(new RegExp("\x0D\x0A", 'g'), "\x0A"))

    return Buffer.concat([
      Buffer.from(`${type} ${objectWithoutCRLF.byteLength.toString()}\x00`),
      Buffer.from(objectWithoutCRLF),
    ])
  }

then the bug disapeared \o/

I tried to set the core.autocrlf git config to false and the bug disapeared too (even without the fix) But I want to keep it to true since I often work with people on Linux (including me)

so it seems that line break issues are not handled in isomorphic-git and I don’t find any related issues, is it possible that I am the only one using this lib on Windows ? 😁 or maybe I am missing something, which is very possible

[acailly]

My fix is a workaround oustide this repo and specific to my use case, so I don’t really have a good fix to submit