Reconsider git.add supporting multiple files

Hi there!

Firstly let me thank you for this project - It has been very useful to us in implementing the git functions we want to support!

That said I am now looking into some key performance issues and am finding the git.add to be a pain point for us.

I am wondering if you would reconsider implementing multi file support for git.add … I am asking because it appears to be very slow to add lots of files in a loop for specific git repositories.

On average it is taking 46ms for each call to await git.add and we are looking to want to add 50-100 files at a time. Even on faster repositories its averaging around 30ms

perhaps something like this? await git.add(file1.txt folder/file2.txt file3.txt file4.txt file5.txt)

[crutchcorn]

I’d like to implement this feature @wmhilton. For my usage, I’d like to see an aggregate of errors rather than failing on first step. I think we could throw an array of Errors? What do you think?

[linonetwo]

I think I need add .

But will this work?

  const allFiles = await git.listFiles({ fs, dir: wikiFolderPath });
  await Promise.all(allFiles.map((filepath) => git.add({ fs, dir: wikiFolderPath, filepath })));

I’m confused because git.listFiles({ fs, dir: '/tutorial' }) will return all files, not just non-added files.

I can see faq have a similar snippet https://isomorphic-git.org/docs/en/faq#how-to-add-all-untracked-files-with-gitadd

const globby = require('globby');
const paths = await globby(['./**', './**/.*'], { gitignore: true });
for (const filepath of paths) {
    await git.add({ fs, dir, filepath });
}

I think both globby(['./**', './**/.*'], { gitignore: true }) and git.listFiles({ fs, dir: '/tutorial' }) will return all files. Which might make git.add run on many files that don’t need to be added?

---

Maybe I should follow https://isomorphic-git.org/docs/en/statusMatrix#q-what-files-have-unstaged-changes

To use:

  const unstagedFilePaths = (await git.statusMatrix({ dir, fs })).filter((row) => row[2] !== row[3]).map((row) => row[0]);
  await Promise.all(unstagedFilePaths.map((filepath) => git.add({ fs, dir, filepath })));