question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Yet another issue about how many sets of files to ship

See original GitHub issue

I’m sorry, I can’t let go of this. One last time:

We should ship an iter-tools-es library which contains sources which are only transpiled down to the level of the most current ecmascript specification that is at least implemented in node. This code will be used in applications which transpile their dependencies to the desired level, or are able to rely on being run in a current node version. The main iter-tools library will be as it is now, though I’d say it wouldn’t be out of line to remove the non-es5 files eventually.

I’ll do the work on the build to make it happen.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:11 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
conartist6commented, Feb 2, 2019

Actually though I think jest should work fine. It’s in node, and it can run any code that node knows how to execute. They reason it would be breaking is that it will always run the code through a transpiler first. It needs to do this to convert imports/exports into something node can understand.

When we don’t pre-transpile at all, that transpiler will choke if the appropriate sytnax isn’t supported. In this case node is more permissive than babel’s baseline. This is, btw, why web users who transpile deps do not (currently) want to import the es2018 files, and won’t until the current draft language spec becomes published. We can fix this if we cause jest to own the transpilation itself, by just adding the @babel/plugin-syntax-async-generators plugin to the configuration jest uses to run the es2018 tests.

Now that I thought through that properly, I will fix it today.

1reaction
conartist6commented, Feb 2, 2019

I mean jest is meant to do the transpilation step itself, which works better since then it has sourcemaps and everything. We have a rather strange jest setup where we transpile ahead of time.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Yet Another Hot Take on "Folders versus Tags"
Folders are controversial in personal knowledge management circles. The common refrain I see is “why do you need folders if you have tags?...
Read more >
Change permissions for files, folders, or disks on Mac
Assign permissions to users and groups · On your Mac, select a disk, folder, or file, then choose File > Get Info. ·...
Read more >
Share OneDrive files and folders
Use OneDrive as a cloud backup to share your files and folders with others. Learn how to control permissions, allow editing, or set...
Read more >
Set an expiration date for file access
Open a file in Google Drive. · Click Share. · Find the user and next to the user's name, click the Down arrow...
Read more >
Limited Data Set (LDS) Files
Data Copies: You may not make duplicate copies of CMS data. Data Shipping: CMS will only ship LDS data to a Requester or...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found