question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

docs: make GHA default, docker optional

See original GitHub issue

See e.g. https://partner.github.com/integration-resources/2020/11/24/pattern-setting-up-a-cli-on-github-s-hosted-runners.html

Would make it super easy to set up:

jobs:
  run:
    runs-on: [ubuntu-latest]
    steps:
      - uses: actions/checkout@v2
      - uses: iterative/cml@v1
      - name: 'Train my model'
        ...
        cml-send-comment report.md

EDIT:

- uses: actions/setup-node@v1
- uses: iterative/setup-cml@v1

works well but needs better documentation. Any objections to making it more prominent than container: docker://? Would fix e.g. #360

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

2reactions
DavidGOrtegacommented, Apr 22, 2021

@casperdcl @0x2b3bfa0 actions/setup-node@v1 might not be needed at all since its de facto in GHA.

I encourage using docker of course but not our image in GHA but the user’s. Thats why we changed CML a bit. Our cml.dev examples pushes the user to use the action instead our container but seems that we forgot this here?

I wont think that this fix #360 unfortunately since we have to support Gitlab and that job (better tagging) has to be done anyway.

1reaction
casperdclcommented, Apr 22, 2021

Well actions/setup-node@v1 is needed if you want to pin the version or often needed in self-hosted but I’m sure you knew that. Will certainly point it out in the docs…

I think the usual point of container: docker:// is for end-users to define their own containers. CML’s containers are to me more of a proof-of-concept than something we should be actively recommending people use.

Read more comments on GitHub >

github_iconTop Results From Across the Web

GitHub Actions cache - Docker Documentation
This cache storage backend requires using a different driver than the default docker driver - see more information on selecting a driver here....
Read more >
Creating a Docker container action - GitHub Docs
In this guide, you'll learn about the basic components needed to create and use a packaged Docker container action. To focus this guide...
Read more >
Build images on GitHub Actions with Docker layer caching
Save hours of googling and learn how to build images on GitHub Actions with proper Docker layer caching. With Docker's BuildKit capabilities ...
Read more >
Traefik Docker Documentation
Defines a default docker network to use for connections to all containers. This option can be overridden on a per-container basis with the...
Read more >
GitLab Docker images
As another option, you can install an MTA directly in the GitLab container, ... By default, Docker allocates 64MB to the shared memory...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found