question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

multiple `cml pr` runs

See original GitHub issue

If the data is changed after a PR it’s going to run again generating strange branch names.

experiment-cml-pr-da72cf16-cml-pr-da72cf16-cml-pr-da72cf16

Things to consider:

  • If we revert the state use send-comment to comment into the new PR via cml send-comment --pr --commit-sha HEAD wont work
  • Do not take into account current branch name to avoid concatenation
  • Take into account file changes to generate the branch name also we have to consider #792

I wonder if is practical to fix it, I mean, should cml pr allow double execution? Which ones would be those plausible scenarios?

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
DavidGOrtegacommented, Nov 5, 2021

@casperdcl not really that complex, assuming that we are not rolling back the only issue here is more:

  • a naming issue
  • the only rollback to have into account is the user.name user.email
  • add the parameters to even allow the pr name as @daavoo suggested.

I would not consider it even an epic in terms of big.

1reaction
DavidGOrtegacommented, Nov 5, 2021

@0x2b3bfa0 Im attacking them in a PR

Read more comments on GitHub >

github_iconTop Results From Across the Web

cml pr: is racy, generates a PR for different submissions · Issue ...
I am not quite sure here why cml is creating a PR with content that is already in the repo (even if the...
Read more >
comment | CML
By default PR comments are created, with a fallback to creating commit comments. ... Repeatedly running cml comment create may produce too many...
Read more >
The Progression of Chronic Myeloid Leukemia to ... - NCBI
Myeloid leukemia comes in two major forms, including acute and chronic. · The genetic changes between the two chromosomes involve a shortening of ......
Read more >
CML Installation Guide - Cisco Modeling Labs 2.4 - Document
When you run a network topology simulation in CML, each node in the topology runs as a VM on the CML server. When...
Read more >
CML Monitoring, Chronic Myeloid Leukemia Patient Resource
As a CML patient, if you do not monitor your disease, you run the risk of ... Monitoring uses multiple lab tests. 3...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found