Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

support comment `--update` with default `GITHUB_TOKEN`

See original GitHub issue

CML comment --update requires a user-defined PAT. Can we change the implementation to work with the default token too?

Would help a lot with user-friendliness of #1017.

ref: https://cml.dev/doc/ref/send-comment#github
discussions:
- #888
- https://github.com/iterative/cml.dev/pull/271#discussion_r925462960

Issue Analytics

State:
Created a year ago
Reactions:1
Comments:14 (12 by maintainers)

Top GitHub Comments

2reactions

rogermparentcommented, Jul 27, 2022

From https://github.com/iterative/cml.dev/pull/271#discussion_r925524184

The one thing I could see in the code is that create-or-update-comment gets its octokit through @actions/github’s core.getOctokit while CML’s GitHub driver gets it through @octokit/rest’s Octokit constructor, seemingly in order to add the throttling plugin.

1reaction

dacbdcommented, Aug 5, 2022

Again, espescially for the github api, comment on an issue differs from a comment on a commit.

There’s also an action for creating commit comments that also doesn’t seem to require a PAT.

Indeed @rogermparent it looks like you are correct and I would say that it appears cml send-comment works fine with the default github token