Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

build: windows: investigate improper version

See original GitHub issue

https://github.com/iterative/dvc/releases/tag/0.50.0

dvc-0.50.0.a54a34.mod.exe

should be

dvc-0.50.0.exe

Issue Analytics

State:
Created 4 years ago
Comments:13 (10 by maintainers)

Top GitHub Comments

1reaction

paredcommented, Jul 9, 2019

I am closing the issue, next release should not have such problems.

1reaction

paredcommented, Jul 8, 2019

Ok so here is why we get this strange number of version:

when installing we get the version of dvc to properly name executable
if current branch is tagged and unchanged, we will name it as version number (dvc-0.50.0.exe)
if something has been changed, we will add first 6 letters of revision sha, which results in dvc-0.50.0.a54a34.mod.exe

But why is it happening on freshly checked out 0.50.0 version?

to install it on windows we need to download some dependencies (dvc_left.bmp, dvc_up.bmp, dvc.ico) using dvc.
calling dvc cause repo initialization
repo by default should ignore file list
problem is that .gitignore on this revision did not included /repos (which is ignored here)
pulling causes adding /repos to .gitignore, branch is unclean
during installation new version name is introduced, because branch is not clean

Proposed solution

introduce /repos to master .gitignore to avoid same bug in the future
we could replace released windows binary with build that has been build after git reset --hard, which should follow pulling dvc_left and the rest