question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

See how much new version of python-benedict impacts us

See original GitHub issue

The recent release of python-benedict has monkeypatched JSONEncoder to always use python-based encoder (instead of C-based encoder.

This monkeypatching happens during import. https://github.com/iterative/dvc/blob/a7f01b65a5cd1654b74e4aa5651063f2b118831d/dvc/utils/collections.py#L85

As we only use it during exp run --set-params, we need to see how much it affects us. Also how important is the performance for the exp run? Do we save large directories and files during exp run?


Note: Simple benchmark shows it causes 2x-4x degradation.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:1
  • Comments:8 (3 by maintainers)

github_iconTop GitHub Comments

5reactions
pmrowlacommented, Aug 30, 2021
1reaction
skshetrycommented, Aug 30, 2021

Discussed with @efiop to get rid of the dependency, we only use it in --set-params. We need to see what it’ll take to replace it.

Read more comments on GitHub >

github_iconTop Results From Across the Web

python-benedict - PyPI
Latest version. Released: Nov 26, 2022. python-benedict is a dict subclass with keylist/keypath support, normalized I/O operations (base64, csv, ini, json, ...
Read more >
Python-benedict: Dict Subclass with Keylist/keypath Support
python -benedict is a dict subclass with keylist/keypath support, I/O shortcuts ( base64 , csv , ini , json , pickle , plist...
Read more >
Released python-benedict 0.24.0 - Reddit
Hello! I just released an update of python-benedict with .ini files format support. For those who don't know it yet, it's a dict...
Read more >
python-benedict - Read the Docs
python -benedict · Overview · Downloads · Search · Builds · Versions. Versions.
Read more >
Issues · fabiocaccamo/python-benedict - GitHub
... csv, ini, json, pickle, plist, query-string, toml, xls, xml, yaml), s3 support and many utilities. - Issues · fabiocaccamo/python-benedict.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found