python3.10 compatibility
See original GitHub issueMotivation for the feature
Python3.10 is standard now: Ubuntu 22.04 came out last month and uses it as its default. But ivadomed is only marked compatible up to 3.9, meaning it cannot be installed on Ubuntu 22.04, or anyone else using an up-to-date system.
This follows https://github.com/ivadomed/ivadomed/issues/770.
Description of the feature
Change
https://github.com/ivadomed/ivadomed/blob/1da019b80be95d99905579dc66de15538141e487/setup.py#L35
to read
python_requires='>=3.6,<3.11',
and fix anything this breaks.
Additional context
Due to https://github.com/neuropoly/computers/issues/338, ivadomed
now has to hide inside of conda envs set up like conda create -n my_env python==3.8
when we are using it internally on romane.neuro.polymtl.ca
or rosenberg.neuro.polymtl.ca
to do research. And come to think of it, this would affect SCT too, which we usually run on joplin.neuro.polymtl.ca
– except SCT bundles its own conda.
It would be nice to have the flexibility to install ivadomed with the faster pip install --user
or python -m venv
again.
Issue Analytics
- State:
- Created a year ago
- Comments:8 (7 by maintainers)
@kanishk16
Information where to download onnxruntime 1.12 is embedded within the notebook
The notebook [updated ~1 month ago] requirement for onnxruntime 1.12 is mandatory.
Onnxruntime 1.12 needs to be provided as nightly (not just for python, but also for c#, c++ etc. )
onnxruntime 3.12 that supports python 3.10 is scheduled to be released by mid-July. Also, https://github.com/microsoft/onnxruntime/issues/9782 suggests to downgrade to 3.9.x. I was wondering if we could wait till mid-July and in the meantime bump up torch & drop support for python 3.6.