Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Incorrect character count

See original GitHub issue

Count Characters script returns incorrect character count:

This originates from: https://github.com/IvanMathy/Boop/blob/5794294ef9a7f4e35e65c5008b47c1ec3733efd3/Boop/Boop/scripts/CountCharacters.js#L14

The implementation does not account for Unicode quirks which are described in detail here: https://mathiasbynens.be/notes/javascript-unicode#counting-symbols

Corrected implementation using string-length: https://runkit.com/embed/0q9svv0m85db

/cc @borna223 😉

Issue Analytics

State:
Created 3 years ago
Comments:8 (3 by maintainers)

Top GitHub Comments

2reactions

IvanMathycommented, Sep 20, 2020

Hey there! Sorry about the very delayed response.

Digging more into the code you pasted it turns out it was taken from lodash, which is something that’s built in to Boop. I’m opening a PR right now to fix the issue, thank you so much for the help!

2reactions

IvanMathycommented, Jul 25, 2020

Hey there! Thanks for the report, looks like a bug indeed…

Feel free to put in a PR with a proposed solution, otherwise I’ll tackle it in 1.3.0.