question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Compare of two trace instances showing diff at wrong point

See original GitHub issue

Requirement - what kind of business use case are you trying to solve?

Compare should only show differences as red or green.

Problem - what in Jaeger blocks you from solving the requirement?

Firstly wanted to say that the new compare feature is great. However when trying it out on the Istio bookinfo example I noticed that it is showing a particular node (istio-mixer op: /istio.mixer.v1.Mixer/Check) as being added and removed under the same node - the only difference is that the green version of the node has a child span.

istio-jaeger-compare

The same issue occurs in multiple places in this particular example - shown twice in this image.

Proposal - what do you suggest to solve the problem or improve the existing situation?

If there is no difference between these nodes, then the compare should only be showing the addition of the child span. If there is a difference between these nodes that results in the green/red distinction, then the difference also needs to be included in the graphical representation, otherwise it is not clear.

Any open questions to address

Issue Analytics

  • State:open
  • Created 5 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
tiffoncommented, Jan 3, 2019

I want to note @yurishkuro’s suggestion of showing the options as a series of checkboxes. Enabling a lower-checkbox would automatically enable any checkboxes above. I.E. you cannot have only the first and last checkboxes enabled.

For instance:


Two spans are in the same group iff:

  • They are from the same service
  • They have the same service & operation
  • They have the same ancestral lineage (by service & operation)
  • They are both either parents or leaves
  • They have the same set of children (by service & operation)
0reactions
yurishkurocommented, Sep 25, 2018

The current comparison is very ancestor oriented, which can be problematic.

So an interesting interview question - given two compressed trace trees, can we determine through some algorithm if they should be matched at roots or at a subtree of one of them?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Feature Compare—Help | ArcGIS for Desktop
ArcGIS geoprocessing tool that compares two feature classes or layers and returns the comparison results. Feature Compare can report differences with ...
Read more >
Is there a Java library that can "diff" two Objects?
I'm looking for something that can compare two objects of the same type and generate a data structure that represents the differences between ......
Read more >
7.3 - Comparing Two Population Means - STAT ONLINE
Two -Cases for Independent Means. As with comparing two population proportions, when we compare two population means from independent populations, the interest ...
Read more >
Compare and merge two versions of a document
In both cases, Word shows the differences with revision marks. Newer versionsOffice 2011.. Do either of the following: Compare two versions of a ......
Read more >
Comparing Doubles in Java - Baeldung
Then, we'll show how to compare doubles in plain Java and common ... comparing both values with the == operator would produce a...
Read more >

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found