Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Singleton VS new Object
See original GitHub issueHi,
I just realized that api is singleton. What If user wants to create multiple binance api objects based on different api key/secrets? I did few changes and it works now with ‘new’. If you want I can create a pull request for you or following is what I did;
Replaced this;
module.exports = function() {
with
function Binance() { if (!(this instanceof Binance)) { return new Binance(); }
And added
module.exports = Binance;
Usage
var Binance = require('node-binance-api');
module.exports = class MyWrapper {
constructor() { this.binance = new Binance(); }
}
Issue Analytics
- State:
- Created 6 years ago
- Reactions:12
- Comments:18 (12 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
@jaggedsoft here is the diff of what I did. Let me know If you are unable to implement this.
https://www.diffchecker.com/cYkDMgwX
I submitted PR #252 to address the issues of shared variables between singletons.
Testing: