question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Trade updates (websocket) are in fact Aggregate Trade streams

See original GitHub issue

Currently the binance.websockets.trades function subscribes to the @aggTrade stream, while there is a separate @trade stream on the Binance API documentation.

It would be better if the current method was renamed binance.websockets.aggTrades and a new binance.websockets.trades was created, but I guess this would break the compatibility of this module.

I propose then implementing a binance.websockets.recentTrades method (to maintain this convention) on the current version and maybe reevaluating if it is worth breaking the compatibility on the next major version of this module.

What do you think about it? I can submit a PR.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:7 (4 by maintainers)

github_iconTop GitHub Comments

github_iconTop Results From Across the Web

Change Log – Binance API Documentation - GitHub Pages
Please use WebSocket Streams for live updates to avoid polling the API. ... a market data audit, we detected some issues with the...
Read more >
websocket aggregate buy(green) sell(red)
Aggregate trade only represents the trade pair (buy-sell) itself, so you won't be able to know which side (buy or sell) the price...
Read more >
How can I get trade buy/sell data of Binance? - Stack Overflow
I want to get real time trade buy/sell data of BTC via binance websocket. I use this method in following websocket module:.
Read more >
Java-XChange/Lobby - Gitter
The Aggregate Trade Streams push trade information that is aggregated for a single taker order. The Trade Streams push raw trade information; each...
Read more >
Binance Python API – A Step-by-Step Guide - Algo Trading 101
Further, there is also a WebSocket available that enables the streaming of data such as price quotes and account updates.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found