error handling (what's the best way ?)

Hi Jake.

I create my own class called utility where I have functions. Let me clarify two functions of that class.

async writeData(storeName, val, key) {
    const tx = this.db.transaction(storeName, 'readwrite');
    const store = tx.objectStore(storeName);
    store.put(val);
    return await tx.done;
  }


  async readAllData(storeName) {
    const tx = this.db.transaction(storeName, 'readonly');
    const store = tx.objectStore(storeName);
    return await store.getAll();
  }

Now, I use that class in my service worker or in my app. I import this class and use these methods .

Let’s say something like this.

import IndexeddB from './utility.js'

let data = IndexedDB.readAllData('articles');

I am curious about this. If you look at the functions itself, do I have everything set up correctly? I mean I am not using onsuccess and onerror on the request. So return await tx.done (is it fair to say that this will automatically throw if there’s an error and it won’t throw an error if there’s not one, to put this in a better way, where I use those functions, if I put them in try/catch block, it’s all good and I am doing it right?

[jakearchibald]

async writeData(storeName, val, key) {
    const tx = this.db.transaction(storeName, 'readwrite');
    const store = tx.objectStore(storeName);
    store.put(val);
    return await tx.done;
  }

Fwiw, you can just do:

await db.put(storeName, val, key);

And:

const data = await db.getAll(storeName);

See https://github.com/jakearchibald/idb#shortcuts-to-getset-from-an-object-store.

I am curious about this. If you look at the functions itself, do I have everything set up correctly?

Yep, it’s all correct, it’s just avoiding some of the shortcuts.

I mean I am not using onsuccess and onerror on the request.

You don’t need to 😄

So return await tx.done (is it fair to say that this will automatically throw if there’s an error and it won’t throw an error if there’s not one, to put this in a better way, where I use those functions, if I put them in try/catch block, it’s all good and I am doing it right?

Yep, although you don’t really need the await there. See this for details https://jakearchibald.com/2017/await-vs-return-vs-return-await/.

Using the shortcut above:

try {
  const data = await db.getAll(storeName);
  console.log(data);
} catch (err) {
  console.error(err);
}

I’m closing this issue, but feel free to ask follow-up questions.

[jakearchibald]

I’m not really familiar enough with the push API, sorry.