Incorrect type of cursor value
See original GitHub issueI have an IDB scheme https://github.com/translate-tools/linguist/blob/4da90de9e406442ab78df591bad04d7e6b93cdf3/src/requests/backend/translations/idb/schema/v2.ts#L8-L16
Here i use cursor value https://github.com/translate-tools/linguist/blob/4da90de9e406442ab78df591bad04d7e6b93cdf3/src/requests/backend/translations/data.ts#L135
And i found that type of cursor value incorrect, when my test failed. The type is not contains a “keyPath” that i defined here https://github.com/translate-tools/linguist/blob/4da90de9e406442ab78df591bad04d7e6b93cdf3/src/requests/backend/translations/idb/schema/v2.ts#L59-L62
So cursor value contains not only properties of type ITranslationEntry
but also property id
that is auto incremented number.
It’s my temporary fix for test https://github.com/translate-tools/linguist/blob/4da90de9e406442ab78df591bad04d7e6b93cdf3/src/requests/backend/translations/data.test.ts#L40-L42 and i have to refactor a lot of code to remove this unnecessary property.
Let’s improve types. We can add a keyPath
to a IDB scheme and merge it to a cursor value type and in another places when we get values from IDB
Issue Analytics
- State:
- Created 10 months ago
- Comments:9 (4 by maintainers)
I’ll find some time to take a close look at that. Sorry I haven’t so far.
I think my PR #252 solves this issue - add and put accept an object with or without the auto incrementing keyPath being present, but any object returned from the database has the keyPath value defined. Example