Malformed filepaths and output options ignored in 'light' mode

When in light mode (i.e. development), the publicPath or outputPath options are ignored if set and the file output is double-nested.

Steps to reproduce

• Set WebpackConfig.mode / NODE_ENV to ‘development’, or change the FaviconsPlugin.mode to ‘light’
• Set Webpack’s output.publicPath value to somedir/foo
• Set Plugin’s publicPath value to somedir/bar as per the README.
• Build the project
• Observe the generated file path

Expected Setting a FaviconsPlugin.publicPath value of somedir/bar will generate somedir/bar/<favicon> as the output file.

Actual Setting a FaviconsPlugin.publicPath value of somedir/bar will generate somedir/foo/somedir/foo/<favicon> as the output file.

In addition to the double nesting, doesn’t seem like you can override that behavior in order to fix it while in light mode.

[Tofandel]

You need to check for undefined on compilation.outputOptions.publicPath and not boolean Eg: const webpackPublicPath = typeof compilation.outputOptions.publicPath !== 'undefined' ? compilation.outputOptions.publicPath : '/';

Because the publicPath can be an empty string and that needs to be preserved

Also only the webpack public path is used not the options of the plugin… I’ll include it in the PR

[jantimon]

Fixed and released as https://www.npmjs.com/package/favicons-webpack-plugin/v/2.0.0