Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Support favicon version 7 (`npm i favicon` will install version 7+)

See original GitHub issue

Current behaviour 💣

Running a webpack build using favicons 7+ will result in

#27 5.123 /node_modules/favicons-webpack-plugin/src/index.js:562
#27 5.123     throw new Error(
#27 5.123           ^
#27 5.123
#27 5.123 Error: Could not find the npm peerDependency "favicons".
#27 5.123 Please run:
#27 5.123 npm i favicons
#27 5.123  - or -
#27 5.123 yarn add favicons
#27 5.123
#27 5.123 Error [ERR_REQUIRE_ESM]: require() of ES Module /node_modules/favicons/dist/index.js from /node_modules/favicons-webpack-plugin/src/index.js not supported.
#27 5.123 Instead change the require of /node_modules/favicons/dist/index.js in /node_modules/favicons-webpack-plugin/src/index.js to a dynamic import() which is available in all CommonJS modules.
#27 5.123     at loadFaviconsLibrary (/node_modules/favicons-webpack-plugin/src/index.js:562:11)
#27 5.123     at FaviconsWebpackPlugin.generateFaviconsWebapp (/node_modules/favicons-webpack-plugin/src/index.js:403:22)
#27 5.123     at FaviconsWebpackPlugin.generateFavicons (/node_modules/favicons-webpack-plugin/src/index.js:315:21)
#27 5.123     at /node_modules/favicons-webpack-plugin/src/index.js:117:18
#27 5.123     at /node_modules/favicons-webpack-plugin/src/cache.js:155:5
#27 5.123     at CacheFacade.providePromise (/node_modules/webpack/lib/CacheFacade.js:337:24)
#27 5.146 error Command failed with exit code 1.
#27 5.146 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Expected behaviour ☀️

A normal build

Reproduction Example 👾

...
    "favicons": "^7.0.0-beta.3",
    "favicons-webpack-plugin": "^5.0.2",
...

Environment 🖥

Node.js v16.14.0
darwin 21.3.0

│ ├── favicons-webpack-plugin@5.0.2 deduped
│ ├── favicons@7.0.0-beta.3 deduped
│ ├─┬ file-loader@6.2.0
│ │ └── webpack@5.69.1 deduped
│ ├── html-webpack-plugin@5.5.0 deduped
│ ├── webpack-cli@4.9.2 deduped
│ └── webpack@5.69.1 deduped

Issue Analytics

State:
Created 2 years ago
Reactions:14
Comments:9 (1 by maintainers)

Top GitHub Comments

6reactions

ximexcommented, Sep 12, 2022

now favicons v7 stable is released. pls make this lib compatible with it. https://github.com/itgalaxy/favicons/releases/tag/v7.0.0

6reactions

synedra-mpecommented, Apr 14, 2022

yarn audit v1.22.17
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ critical      │ Prototype Pollution in minimist                              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ minimist                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=1.2.6                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ favicons                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ favicons > to-ico > resize-img > jimp > mkdirp > minimist    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://www.npmjs.com/advisories/1067342                     │
└───────────────┴──────────────────────────────────────────────────────────────┘

It would really be nice, that we could make use of favicons 7, which does not depend on old version of minimist.