Help with porting scalajs-react-bridge

Not exactly an issue, but I am trying to get types right while porting scalajs-react-bridge. I have it basically ported and all tests are passing, but I am not sure about the types I have used and I am facing one issue where I can use your help/pointers.

I will like these components to behave similar to div (of type TagOf[_]). Specifically, I will like to use components such as TestComponent in tests passing it arbitrary TagMods (such as onClick, onDoubleClick etc). In other words, I will like to be able to instantiate component in the following way:

   val testComponent = TestComponent(key = "mykey")(onClick --> someCallback)

However, when I do that in my testsuite (as well as real components outside this project), the resulting type for such an expression is TagMod. It looks like there is no implicit conversion from TagMod (unlike TagOf) to VdomElement (which perhaps is intended). As as result, I can’t do val mounted = ReactTestUtils.renderIntoDocument(testComponent).

I also suspect that I am overdoing things with ComponentNoChild and may not actually need it. I am not actually particularly keen on prohibiting children for certain components, but more interested in not requiring an additional set of () for component instances that don’t wish to pass children.

Thanks for your help.

[ramnivas]

FYI and thanks!

This new version supports ‘neo’ and utilizes your improvements here.

https://github.com/payalabs/scalajs-react-bridge

[japgolly]

Awesome, enjoy!

On 14 July 2017 at 11:30, Ramnivas Laddad [e-mail] wrote:

@japgolly https://github.com/japgolly This looks great. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/japgolly/scalajs-react/issues/385#issuecomment-315244885, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMYtzPxJlhV3VuIQj44aW8I702KBmbOks5sNsS_gaJpZM4N3tsZ .