Do the test examples work?

Hi Jared. I’m sorry I’m swamping you with issues at the moment

There are a couple of things about the text examples I’d like clarity on:

await tree.find(MyInnerForm).props().submitForm()

Using await here gives the impression that submitForm returns a promise, which is misleading (relevant lines). If you’re using async validations via validate or validationSchema then it’s going to return immediately before before executeSubmit is executed

Is it better to just use executeSubmit which is sync?

tree.find(MyInnerForm).update().dive()

I’m pretty new to Enzyme so found this confusing. Enzyme tells me I can only call update() on the root wrapper

[codeincontext]

Those tests verify that the function gets called, not whether the await is blocking. I have a strong suspicion that the tests will still pass if you remove the ‘await’ keyword.

Here’s my failing test case:

Fails

  it('handles successful submission', async () => {
    const submitMock = () => Promise.resolve();
    const wrapper = shallow(<ReviewForm submitReview={submitMock} />);
    expect(wrapper.length).to.equal(1);

    const getForm = () => wrapper.update().find('InnerForm');
    const diveFind = query => wrapper.update().dive().find(query);

    await getForm().props().submitForm();

    expect(getForm().props().status).to.deep.equal({ success: true });
    expect(diveFind('Success').length).to.equal(1);
    expect(diveFind('form').length).to.equal(0);
  });

Passes

  it('handles successful submission', async () => {
    const submitMock = () => Promise.resolve();
    const wrapper = shallow(<ReviewForm submitReview={submitMock} />);
    expect(wrapper.length).to.equal(1);

    const getForm = () => wrapper.update().find('InnerForm');
    const diveFind = query => wrapper.update().dive().find(query);

    await getForm().props().submitForm();

    // Wait for yum validations to complete
    await new Promise(r => setImmediate(r));

    expect(getForm().props().status).to.deep.equal({ success: true });
    expect(diveFind('Success').length).to.equal(1);
    expect(diveFind('form').length).to.equal(0);
  });

[jaredpalmer]

Move this discussion to #154