Breaking change with tsdx 0.12.1 with Tailwind babel macro
See original GitHub issueCurrent Behavior
I’m using tailwind.macro
in a React library with Storybook built with tsdx. On tsdx 0.12.0, everything was working as expected as babel macros are supported out of the box.
However, when updating to 0.12.1, my builds stopped working properly with tailwind.macro.
I created a repository with the two versions and a simple component including styled-components and tailwind.macro: https://github.com/fknop/tsdx-tailwind.macro-bug. I also included the two dist folders from the two versions: 0.12.0: https://github.com/fknop/tsdx-tailwind.macro-bug/blob/master/tsdx-0.12.0/library/dist/library.esm.js 0.12.1: https://github.com/fknop/tsdx-tailwind.macro-bug/blob/master/tsdx-0.12.1/library/dist/library.esm.js
As we can see, tw
is not imported anywhere in the 0.12.1 version. This makes any code importing this build failing with the function tw
being undefined.
Tested on both MacOS and Windows 10.
Issue Analytics
- State:
- Created 4 years ago
- Reactions:3
- Comments:7 (2 by maintainers)
Top GitHub Comments
Thank you for the quick fix!
Seems like that confirms my fears in https://github.com/jaredpalmer/tsdx/pull/130#issuecomment-569375532. Great reproduction @fknop !
The importing of
tslib
in 0.12.1 vs. insertion of babel helpers in 0.12 and prior is also a notable difference, related to #412@jaredpalmer I reverted the extraneous changes of #130 in #415