Github Actions templates cache doesn't hit due to hashing bug

Current Behavior

Due to the fact that this line has a glob, it will create a wrong key! Explanation, when the workflow starts it doesn’t have any node_modules, therefore hashFiles('**/yarn.lock') will use only the package’s yarn.lock (as expected), but at the end of the flow, node_modules are installed, hashFiles('**/yarn.lock') will contain all yarn.lock files from node_modules as well, therfore hashFiles('**/yarn.lock') will save the cache on a different key.

Expected behavior

It should relay only on the package’s yarn.lock file.

Suggested solution(s)

Remove the glob from this line https://github.com/formium/tsdx/blob/master/templates/basic/.github/workflows/main.yml#L20.

Additional context

Based on the research that @AllanChain did, https://github.com/AllanChain/blog/issues/98

Your environment

Software	Version(s)
TSDX
TypeScript
Browser
npm/Yarn
Node
Operating System

[allcontributors[bot]]

@agilgur5

I’ve put up a pull request to add @felixmosh! 🎉

[agilgur5]

You should commit your lock files, the question is if it is published to the npm repo.

Yes, that’s what I was talking about. The NPM link I added says they cannot be published, so the inclusion of lockfiles in publishes is specific to Yarn