Linting should include type checking

Current Behavior

const wrong = parseInt(8);

npm run lint reports no problem with this (which is strange, usually should require a second radix param, but this is not important right now)

Desired Behavior

Linting should run tsc --noEmit to catch that Argument of type '8' is not assignable to parameter of type 'string' error

Suggested Solution

Run tsc --noEmit followed by eslint

Who does this impact? Who is this for?

VS Code users (maybe others as well). If file is not open there is no way to get an error report from it, except building

[gustavopch]

@gburnett First, upvote https://github.com/microsoft/TypeScript/issues/27379 to show interest in an official solution from the TypeScript maintainers.

So, yes, there’s a workaround. I started to write it: https://github.com/gustavopch/tsc-files. But, as I mentioned in the “Edit” section of my comment above, type-checking the files that were changed is not enough — we should also type-check all files that depend on the changed ones.

Currently, tsc-files won’t do that, so I’m not even using it in my projects (I’m just type-checking the whole project with tsc --noEmit). I’ve opened an issue describing the problem and proposing a possible solution: https://github.com/gustavopch/tsc-files/issues/6. A PR would be welcome.

[gburnett]

The biggest issue here is that tsdx lint should continue to be able to receive the specific files as arguments so that it works with lint-staged

@gustavopch Is there a workaround for this at the moment?