Possible event listener memory leak

Disclaimer: I’m fairly new to Node 😃

The following event listener in CacheableRequest.js is never removed:

this.cache.on('error', err => ee.emit('error', new CacheableRequest.CacheError(err)));

These listeners will keep accumulating in the scenario where you are reusing a single CacheableRequest to service multiple requests (which I believe is the intention?).

Moreover, the error produced by the cache is not necessarily associated with the current request - it’s a generic error that is broadcast to all listeners.

---

IssueHunt Summary

clement-buchart has been rewarded.

Backers (Total: $80.00)

• issuehunt ($80.00)

Submitted pull Requests

• #82 Clean up store error event listener to prevent memory leak

---

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[IssueHuntBot]

@issuehunt has funded $80.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[clement-buchart]

Hello, I think this is loosely related to this issue : https://github.com/sindresorhus/got/issues/792 I opened in got. In short, the fact that instantiating a new Keyv every time cacheableRequest is instantiated leads to a lot of eventListener being registered, causing a Memory leak for us. One could argue that given that cacheableRequest needs a ‘request’ function in it’s constructor, it’s not super easy to keep a single instance for an application.

It’s probably a naïve approach, but I see 2 potential solutions :

• Either allow a client to pass the Keyv instance in place of the Keyv adapter (which will need an additional boolean parameter in the constructor because Keyv and it’s adapter have nearly identical signature)
• Keep a list of Keyv instance and, when provided with an adapter, check if a Keyv instance already exists for it

@lukechilds What do you think ? Any suggestion on how to fix this ? I would gladly open a MR.