Using the CRD name if no finalizer is provided is not a good default

Unfortunately, CRD names don’t mandate that their group be a valid domain name, therefore using <plural>.<group>/finalizer is not guaranteed to be a valid finalizer name. Possible options for the first part of the finalizer identifier:

• FQN of the associated controller
• CR Kind + package name
• CR Kind / CR simple class name + .javaoperatorsdk.io

Tha last one being the less risky in terms of validation, though https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#finalizers doesn’t specify that the finalizer id be a valid kubernetes name (which it isn’t anyway because of the /) so we probably aren’t constrained to only 63 characters length.

[metacosm]

Existing TLDs are subject to change anytime, so I don’t think it’s reasonable to add them to the validation.

Well, we could retrieve the TLD list from IANA at compile time and then… 😀 </overengineering>

Furthermore one can have their own DNS with any domain name follow the format but not ending with existing tlds.

Good point. I will fix the validation code. We should still strive to generate a valid domain name in the examples and when generating default identifiers, though.

[metacosm]

This will be addressed at the fabric8 client level.