Async does not return the result body

The “async” does return the set status code, but not the body. The provided example does not checks that.

I have provided an updated example (see link below) where I do set a body for the 2 examples already provided by javalin and also added 2 examples using a real life async scenario: obtaining the data from a service that returns a CompletionStage (or CompletableFuture).

https://github.com/Adeynack/javalin/blob/async-does-not-response-with-body/src/test/kotlin/io/javalin/examples/AsyncExample.kt

From that example, we can observe the following results.

/test-custom

$ http http://localhost:5454/test-custom
HTTP/1.1 418 I'm a Teapot
Content-Length: 0
Content-Type: text/plain;charset=utf-8
Date: Thu, 09 Nov 2017 10:57:19 GMT
Server: Javalin

Body is empty.

/test-async

$ http http://localhost:5454/test-async
HTTP/1.1 418 I'm a Teapot
Content-Length: 0
Content-Type: text/plain;charset=utf-8
Date: Thu, 09 Nov 2017 10:57:56 GMT
Server: Javalin

Body is empty.

/test-future

Run 1

$ http http://localhost:5454/test-future
HTTP/1.1 418 I'm a Teapot
Content-Length: 13
Content-Type: text/plain;charset=utf-8
Date: Thu, 09 Nov 2017 10:58:50 GMT
Server: Javalin

I am a Teapot

With a body!

Run 2

$ http http://localhost:5454/test-future
HTTP/1.1 418 I'm a Teapot
Content-Length: 0
Content-Type: text/plain;charset=utf-8
Date: Thu, 09 Nov 2017 10:59:10 GMT
Server: Javalin

No more body 😦

/test-future-long

$ http http://localhost:5454/test-future-long
HTTP/1.1 418 I'm a Teapot
Content-Length: 0
Content-Type: text/plain;charset=utf-8
Date: Thu, 09 Nov 2017 10:59:49 GMT
Server: Javalin

Body is empty.

[tipsy]

I’ll just close this, as it can’t really be fixed in an acceptable way. I have deprecated the method.

[tipsy]

@Adeynack, what do you think about removing this way of doing async in favor of ctx.result(future)?