Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Context.formParamMap() is not safe for repeated calls
See original GitHub issueActual behavior (the bug) When a non-multipart form is submitted, and form parameters extracted, form parameters subsequent to parameter 1 are empty.
Expected behavior The form parameters not to be empty
To Reproduce
Post a non-multipart form, such that Context.formParamMap calls ContextUtil.splitKeyValueStringAndGroupByKey(body()).
Additional context
The current implementation of Context.body() calls bodyAsBytes(), which is a mutative operation, consuming the entire stream. Subsequent calls to bodyAsBytes() will reach EOF on the stream, yielding an empty body, which in turn presents itself as an empty formParamMap().
Given that bodyAsBytes() summons a new buffer in any event, it probably makes sense to make this a lazily initialized property of Context.
I still owe you a PR from my prior raised issue, happy to send this one over alongside it.
Issue Analytics
- State:
- Created 5 years ago
- Comments:5 (3 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
Happy to close!
@stevebarham do you want to discuss this more, or should the issue be closed?