Exception handler trumps 404 error handler since Javalin 2.5.0

Actual behavior (the bug) Since version 2.5.0, when I define an exception handler as well as an error handler for status code 404, a 500 response as created by the exception handler is returned. The error handler does not seem to have any effect.

Expected behavior When I register both an exception handler and an error handler for status code 404, 404 responses are not transformed into 500 responses. This is the behaviour on Javalin 2.4.0 and earlier versions.

To Reproduce Here is a small demo application:

import io.javalin.Javalin;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class Main {

    private static final Logger log = LoggerFactory.getLogger(Main.class);

    public static void main(final String[] args) {
        final var server = Javalin.create()
                .port(8000)
                .error(404, ctx -> ctx.result("NOT FOUND!"))
                .exception(Exception.class, (e, ctx) -> {
                    log.error("Exception was thrown", e);
                    ctx.result("BOOM!");
                })
                .get("/hello", ctx -> ctx.result("WORLD!"))
                .start();
        Runtime.getRuntime().addShutdownHook(new Thread(server::stop));
    }

}

In 2.4.0, a request to http://localhost:8000/doesnotexist returns a 404 with the response body NOT FOUND!.

In 2.5.0, the same request returns a 500 with the response body BOOM!.

[tipsy]

You’re very welcome. This was a pretty serious bug, so I’ll probably release a new version soon.

[dwestheide]

Thank you very much for putting out a release with a fix so quickly. You rock! 👏