Suppport setting own ServletContextHandler on embedded Server

I have some existing servlets that I want to use in combination with Javalin. When I set the server’s handler to use the servletContextHandler it seems to complete overwrite any Javalin endpoints. Is it possible to do this?

embeddedServer(new EmbeddedJettyFactory(() -> {
    Server server = new Server();
    ServletContextHandler servletContextHandler =
		new ServletContextHandler(ServletContextHandler.SESSIONS);
    servletContextHandler.setContextPath("/someServletContextPath");
    servletContextHandler.addServlet(someServlet.class, "path");
    server.setHandler(servletContextHandler);
    return server;
}

[havenotfear]

I have not started on it yet. On the back burner probably for another week or so. I do plan on working on it.

[tipsy]

Let’s see. The handlers are added like this:

server.apply {
    handler = attachHandlersToTail(server.handler, HandlerList(httpHandler, webSocketHandler, notFoundHandler))
    connectors = connectors.takeIf { it.isNotEmpty() } ?: arrayOf(ServerConnector(server).apply {
        this.port = port
    })
}.start()

I wrote a tutorial a while back for custom handlers: https://javalin.io/tutorials/prometheus-example

.embeddedServer(new EmbeddedJettyFactory(() -> {
    Server server = new Server(queuedThreadPool);
    server.setHandler(statisticsHandler);
    return server;
}))

But that looks a lot like what you’re doing. I’m guessing your ServletContextHandler takes it upon itself to handle 404s? Ideally the request should just move to the next handler in the list, but I’m not all that familiar with how ServletContextHandler behaves in a HandlerList.