Testing SSE endpoints with JavalinTest

Problem:

I want to achieve the maximum coverage of my controller tests.

What have I managed so far:

By following this tutorial I’ve managed to write a test that covers every normal method on my controller using the “Functional/integration” methodology described by the tutorial.

What I want to do:

listenToParameterChanges is a method on my controller invoked by an SSE declaration in my server description.

I want to make sure that method is also tested properly, is there a way to test it while maintaining the same methodology or should I change my methodology to the one described under “Unit” on the tutorial to cover that portion of my controller?

[tipsy]

@dzikoysk https://github.com/tipsy/javalin/commit/0e947377724bd32da28b1707a33c9d79b9f53386

Turns out we have two bugs:

1. Javalin doesn’t release the request when the emitter is closed
2. Javalin doesn’t call closeCallback when the user manually calls close()

I changed the close() method to also trigger the closeCallback, then I called the close() whenever the emitter is closed. This should fix both bugs.

[Incognitowski]

@tipsy sorry for the delayed answer.

I think client could be expanded to include SSE, since it’s just a HTTP connection. Having a .close() on client seems fair enough?

I believe that wold be perfect.

I’ll give it a shot with okhttp-sse as well.