question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Open up Parameters class for integration in Spring Boot Admin project

See original GitHub issue

In the Spring Boot Admin project there is an effort to integrate Javamelody as part of the user interface. A pull request exists, but it is currently blocked, because it depends on accessibility to the net.bull.javamelody.Parameters class.

https://github.com/codecentric/spring-boot-admin/pull/450

Would it be possible to make the methods addCollectorApplication and removeCollectorApplication publicly available? That way it is possible to dynamically add applications to the javamelody dashboard once these applications register themselves with service discovery.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:8 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
evernatcommented, Aug 15, 2017

I would be ok to add the 2 public static methods in the CollectorServlet class. That is:

public class CollectorServlet extends HttpServlet {
...
	public static void addCollectorApplication(String application, List<URL> urls) throws IOException {
		Parameters.addCollectorApplication(application, urls);
	}

	public static void removeCollectorApplication(String application) throws IOException {
		Parameters.removeCollectorApplication(application);
	}
...
}

Is it ok for you?

0reactions
evernatcommented, Sep 1, 2017

@anderius I suggest that you keep a Set (or a Map) of the added applications in your own bean. So you can add all applications the first time, then add only the new applications which are not already in your Set.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Spring Boot Admin Reference Guide - GitHub Pages
The Spring Boot Admin Client registers the application at the admin server. This is done by periodically doing a HTTP post request to...
Read more >
Building a RESTful Web Service with Spring Boot Actuator
Spring Boot Actuator is a sub-project of Spring Boot. It adds several production grade services to your application with little effort on your...
Read more >
A Guide to Spring Boot Admin | Baeldung
Learn how to monitor and manage the Spring Boot applications using Spring Boot Admin.
Read more >
Spring Boot Admin | DevGlan
In this article, we will discuss Spring Boot Admin by utilizing actuator endpoints and create separate projects for sample admin server and ...
Read more >
Spring Boot Admin Integrates with Diagnostic Tool Arthas
This article describes how to integrate Arthas into the Spring Boot Admin. 1. Arthas is a diagnostic tool for Java open sourced by...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found