Missing shadows after upgrading from 3.7.0 to 3.7.5 (and 3.8.5)

We are using Javers to historize our domain objects and it is doing a great job! However, after upgrading from 3.7.0 to 3.7.5 and above the following junit tests in our spring boot project fail (the branch is configured to use javers 3.8.5 at the moment): Missing Study Shadows Missing Survey Shadows

Both tests use the following piece of code to load the shadows with limit=5 and skip=0 (from GenericDomainObjectVersionsService.java)

public List<T> findPreviousVersions(String id, int limit, int skip) {
    T domainObject = repository.findOne(id);

    if (domainObject == null) {
      return null;
    }

    QueryBuilder jqlQuery = QueryBuilder.byInstance(domainObject)
        .withScopeDeepPlus(Integer.MAX_VALUE).limit(limit).skip(skip);

    List<Shadow<T>> previousVersions = javers.findShadows(jqlQuery.build());

    return previousVersions.stream().map(shadow -> {
      T domainObjectVersion = shadow.get();
      if (domainObjectVersion.getId() == null) {
        // deleted shadow
        domainObjectVersion.setLastModifiedBy(shadow.getCommitMetadata().getAuthor());
        domainObjectVersion.setLastModifiedDate(shadow.getCommitMetadata().getCommitDate());
      }
      return domainObjectVersion;
    }).collect(Collectors.toList());
  }

Both tests expect to get 3 shadows (1 initial commit + 2 updates) but do get only 2 shadows.

Please let me know if this is an intended change introduced with 3.7.5 or if this is an unintended side effect from the performance improvements introduced with 3.7.5

[bartoszwalacik]

@rreitmann seems correct but could be slow. I would be better to have correct & fast paging for Shadows in JaVers itself. Let me check it. I’ll be back to you.

[rreitmann]

Ok, I did not know that. Thx, for letting me know.