Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Backport switch to `prop-types` package to the v1 branch to add compat with react 16

See original GitHub issue

After updating to react 16, I encountered the following error:

TypeError: Cannot read property 'shape' of undefined
./node_modules/react-css-themr/lib/utils/themr-shape.js
node_modules/react-css-themr/lib/utils/themr-shape.js:7

Would be great to add a 1.8 release with the switch to the prop-types package to maintain compatibility for people like us stuck on toolbox v1 for now.

Issue Analytics

State:
Created 6 years ago
Reactions:3
Comments:5

Top GitHub Comments

1reaction

manuphatakcommented, Oct 19, 2017

published a built version: https://github.com/bionikspoon/react-css-themr/tree/react_16_build

This fork is working it’s way into production on my team. Conversation here: https://github.com/react-toolbox/react-toolbox/issues/1703

{
  "dependencies": {
    "react-css-themr": "git://github.com/bionikspoon/react-css-themr.git#react_16_build"
  }
}

1reaction

manuphatakcommented, Oct 13, 2017

Created a branch with this work. https://github.com/javivelasco/react-css-themr/compare/1.7.2...bionikspoon:react_16

Tests are passing. I don’t know your release process.

Top Results From Across the Web

Update to be react 16 compitable · Issue #83 - GitHub

Backport switch to prop-types package to the v1 branch to add compat with react 16 #75. Open. TASK: Update react and react-dom to...

Typechecking With PropTypes - React

To run typechecking on the props for a component, you can assign the special propTypes property: import PropTypes from 'prop-types'; class Greeting extends...

material-ui/core/CHANGELOG.md - UNPKG

We plan to add a deprecation for any breaking change in v5 that allows it. ... The best support for React 17 will...

Releases - styled-components

Fix dynamic creation React warning for React v18, backported to v5 by ... Add "engines" to package.json (currently set to Node 10, the...

prop-types | Yarn - Package Manager

Runtime type checking for React props and similar objects. You can use prop-types to document the intended types of properties passed to components....