Error Handling?

There seems to be no error handling. I ran into an error where I had set the files limit to 1 and was trying to upload multiple files and busboy wasn’t emitting an event but apollo-upload-server was create a promise that would never resolve and the request would start hanging.

1. We fist need to handle the special limits events in busboy here, https://github.com/mscdex/busboy#busboy-special-events and reject the promise if any of those are raised.
2. And the inner promise should reject if the mapFieldname does not match the fieldName,

if (fieldName === mapFieldname) { // }
else { reject(new Error(`Field name mismatches ${fieldName} !== ${mapFieldname}`));

1. I guess we should resolve the top level promise only on the busboy finish event.

And finally maybe the request.pipe/busboy might have some error events which need to consumed and reject the promise for safety sake.

[jaydenseric]

I have been working on error handling all day, and have made a lot of progress but it might take a bit longer to work out the kinks. It’s amazing how little info there is on handling edge cases with Node.js streams and multipart requests, such as handling users aborting the request halfway though. Even basic questions, like how to deliberately interrupt and shutdown a stream with an error are hard to Google.

In the end, File upload scalar promises will reject with meaningful errors for all the various cases, and if an error such as a file size limit or aborted request happens when a file is still being streamed the stream will receive a meaningful error event. If a request is aborted, cutting off a stream, the stream will have a truncated property like what busboy does for files that are too big.

Really complicated 😓

[SergioSuarezDev]

I just ran into this problem too. I have a maxFileSize of 25mb set and tried to upload a 100mb file. No error was thrown and I ended up with a corrupt 25mb file on my server. I expected this to error out.

I have same problem and I created a issue: https://github.com/jaydenseric/graphql-upload/issues/274