Upload of two and more scalars

Hi! Thanks for repository.

I’m having a problem with uploading of two scalars.

My input with two scalars for mutation is:

input createTrainingInput {
  name: String!
  level: TrainingLevel!
  introduction: String!
  workoutDuration: String!
  description: String!
  goals: [String]!
  requirements: [String]!
  overallDuration: Int!
  intensity: Int!
  price: Int!
  promotionalVideo: Upload!
  coverPhoto: Upload!
}

When I upload small plain text files, everything is ok.

But when I’m trying to upload video one of the promises is in ‘pending’ state for a long time, until FileStreamDisconnectUploadError is thrown.

Resolvers code:

const { coverPhoto, promotionalVideo, ...properties } = input;

const [
    { stream: coverPhotoStream, filename: coverPhotoFilename },
    { stream: promotionalVideoStream, filename: promotionalVideoFilename },
] = await Promise.all([
    coverPhoto,
    promotionalVideo
]);

Version of apollo-upload-server is 5.0.0.

Please, advice what can be done in this situation.

Thank you.

[hkjeffchan]

Do NOT do this, this will block the stream and will raise error.

    const { stream: coverPhotoStream, filename: coverPhotoFilename } = await coverPhoto;
    const { stream: promotionalVideoStream, filename: promotionalVideoFilename } = await promotionalVideo;

Wrap the stream operation in promise one by one, await all and then execute the rest operation. It should be something like this. I haven’t tested it but hopefully you get the idea.

createTraining: async (root, { input }, context) => {
    const { user } = context;
    const coach = await Coach.findOne({ user });
    const { coverPhoto, promotionalVideo, ...properties } = input;

    await Promise.all(
         new Promise( (resolve, reject) => {
              const { stream: coverPhotoStream, filename: coverPhotoFilename } = await coverPhoto;
              const photoFilename = getUploadPath('training_videos', coverPhotoFilename);
              await storage.save({
                      stream: coverPhotoStream,
                      filename: photoFilename
              });
              resolve(true);
         }),
         new Promise( (resolve, reject) => {
             const { stream: promotionalVideoStream, filename: promotionalVideoFilename } = await promotionalVideo;
             const videoFilename = getUploadPath('training_cover', promotionalVideoFilename);
             await storage.save({
                   stream: promotionalVideoStream,
                   filename: videoFilename
             });
             resolve(true);
         })
    );

    const training = new Training({
        coach,
        coverPhoto: coverPhotoFilename,
        promotionalVideo: videoFilename,
        ...properties
    });
    await training.save();
    return { training };
}

[hkjeffchan]

After hours of research, I finally found the solution.

We cannot do something like this:

await Promise.all([
    coverPhoto,
    promotionalVideo
]

Instead, we should create a new Promise for each desired operation and await Promise.all for all operations.