question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make hotkeys events removable

See original GitHub issue

Hi!

We just started to use this library in our VueJS project, the shortcut system works great! But we have an important downfall with this library in our single page app, we must remove subscribed events when there are not necessary anymore.

For this, it will be very helpful to have a method destroy() to unsubscribe all the event listeners added by the library. For now, we use the unbind() method but its not enough and the current behavior can lead to memory leaks.

We can contribute with a PR but we wanted to see if there were any cons to add this method to the library.

I’m available if there’s any question. 👍

Issue Analytics

  • State:open
  • Created 4 years ago
  • Reactions:1
  • Comments:12 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
jaywcjlovecommented, Aug 14, 2019

@yakov116 Welcome to improve the documentation.

1reaction
yakov116commented, Aug 14, 2019

@jaywcjlove ok. Side thing do you mind if i send in a pr to improve the docs?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Unpreventable keyboard shortcuts in javascript - Stack Overflow
So far, I've got Ctrl+N , Ctrl+Shift+N , Ctrl+T , Ctrl+Shift+T , Ctrl+W , Ctrl+Shift+W , all from Google Chrome. Then there's the...
Read more >
Make Frequent User Actions Easier by Defining Hotkeys
Make Frequent User Actions Easier by Defining Hotkeys · Open the setup and go to User Interface > Hotkeys > Commands. · Select...
Read more >
Customize keyboard shortcuts in Photoshop - Adobe Support
Learn how to customize keyboard shortcuts in Adobe Photoshop. Find out how to define new shortcuts, clear shortcuts from commands or tools, ...
Read more >
Visual Studio Code Key Bindings
Here you will find the complete list of key bindings for Visual Studio Code and how to change them.
Read more >
Customizing Keyboard Shortcuts - VEGAS Magazine
For instance, in VEGAS Pro, the default keyboard shortcut for the Ignore Event Grouping feature is Ctrl+Shift+U and the shortcut for removing ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found