SHOW_TOOLBAR_CALLBACK no longer supports lambda

in my setup i always have seperate dev settings and in those settings i enable debug toolbar for all requests. i’ve always done that with the following config

DEBUG_TOOLBAR_CONFIG = {
    'SHOW_TOOLBAR_CALLBACK': lambda request: True,
}

after updating my virtualenv this morning i started getting errors that i’ve tracked down to trying to run rsplit on func_path

line 45 of debu_toolbar/middleware.py:

    mod_path, func_name = func_path.rsplit('.', 1)

it looks like the meaning of SHOW_TOOLBAR_CALLBACK may have changed to require a string and not support a callable. if that’s the case i’m not sure what the solution would be. i’d rather not have to define a function somewhere and point this at it just to return true. i’d prefer if SHOW_TOOLBAR_CALLBACK supported being presented a callable.

[aaugustin]

All Django settings have primitive values, to avoid the temptation to import stuff in settings. The Debug Toolbar follows this philosophy. I’m sorry that it makes your use case marginally less practical, but I still think it’s a good trade-off for the community at large.

I would suggest the following (untested) code:

DEBUG_TOOLBAR_CONFIG = {
    'SHOW_TOOLBAR_CALLBACK': "%s.true" % __name__,
}

def true(request):
    return True

[dcramer]

I dont think developers being ignorant is a good reason to remove simplicity 😃